Hardcore Ender Expansion

Hardcore Ender Expansion

2M Downloads

FPS issues caused by Spatial Dash Gem

FrederikTessmann opened this issue ยท 10 comments

commented

Spamming the Spatial Dash Gem causes a significant drop in frame rate that persists until relog.
Seems to be related to chylex.hee.proxy.FXClientProxy.spatialDash(FXClientProxy.java:170)

commented

I can confirm I'm having this issue in 1.8.6

Browsing the F3 graph tool it looks like it raises root/gameRenderer/level/litParticles up to ab obscene amount - Normally it is 0.13% in my game but firing it off just seems to increase it by 5-10% each fire, regardless of whether it hits or not. FPS, imaginably, drops the more I use this item. Solutions are reconnect to the server, switch to a different dimension, restarting the game.. But it would be nice if I didn't have to do those :P

commented

It's been about 2 minutes and the usage on it is only going up. It's gone from 70% to 80% as I was typing the above.

commented

Yes. The EntityEnergyClusterFX particles are not being deleted properly. I think it's caused by them never reaching their target block in EntitySoulCharmFX.onUpdate() at line 75.

commented

That's an artifact of messy code structure, the particles are deleted after a set amount of time - the target block has nothing to do with it.

commented

Okay looks like I was looking at the old FX code in branch HEE1-1.7.10.
But the FPS issues are happening in the current release on curse.

commented

Even with the cooldown?

commented

No, HEE 1 is discontinued and the issue is open for HEE 2.

commented

It's still a problem in HEE 1, though. Is there no way to disable the particles or force-delete them or something? It completely kills the Spatial Dash Gem as something usable.

commented

I suppose there's no chance of any kind of fix or workaround for this issue (Besides restarting), is there?

commented

Yea, there's a lot of problems in HEE 1. Switching particle setting to minimum/off may decrease the amount of particles, I can't remember.