Hardcore Ender Expansion

Hardcore Ender Expansion

2M Downloads

[ANSWERED] Some safety in case of invalid recipes

Mrkol opened this issue ยท 3 comments

commented

chylex.hee.mechanics.orb.OrbAcquirableItems.initialize() is pretty unsafe. There should be more null-checks, because certain mods can register their recipes wrongly, and you don't want to get false reports like #38.

commented

Honestly it's a good thing that he crashes. As allowing shit like this to get in the game, will inevitably break other mods and maybe even break it more catastrophically than a start up crash.

commented

They can register their recipes wrongly, but I don't have to make my mod work with them. It's not even my mod's fault, the crash happens when my code uses VANILLA CODE to simply get the damage value of an item, which should NEVER happen.

commented

Fun fact, if you crash inside a crafting table (which is one of the things that happens with faulty recipes), you lose all the items in the table.