Hardcore Questing Mode [FORGE/FABRIC]

Heya Dusk and team!

I hope I didn't miss this issue in my search, but I had yet to see it reported.
Basically, this part of code:

HQM/src/main/java/hardcorequesting/client/interfaces/edit/GuiEditMenuItem.java

Line 502 in 42109aa

String search = fluid.getLocalizedName(null);

passes null to the Fluid.getLocalizedName(FluidStack) method. There is a method of the same name that omits the stack, which might be more appropriate, since me personally assumed that FluidStack to not be null.

It caused the issue here:
BluSunrize/ImmersiveEngineering#1926
Forge Version and other mods are found in the crashlog of that issue, but as far as I can see, this is between IE and HQM, and the null being passed.
I'll be adding a nullcheck there myself, but I'd encourage changing that method to the version without parameters :V

I think this crash is related. Just thought I would post it and ask if there is a work around?

crash-2017-03-14_18.12.37-client.txt

Yeah that's basically the result of the issue. Null passed to a method where some users might not expect a null.

Also seeing this error, but on ticking entity.
NPE

I can provide more from the log if required.

Share to