Hardcore Questing Mode [FORGE/FABRIC]

Hardcore Questing Mode [FORGE/FABRIC]

16M Downloads

[1.16.5] A small issue I noticed with some text boxes.

vizthex123 opened this issue ยท 7 comments

commented

I noticed that text written on the right side of a quest doesn't render apostrophes properly, whereas on the left side it works fine.

Pics attached.
Left side:
image

Right side:
image

Text input on the right side:
image

commented

Not sure what "Right side" editable text you're referring to. Can anyone elaborate?

commented

Probability the right and left side of the quest book itself

commented

Not so sure. It has text on the right side (which seems to work while), while the left side is an image.
quest book

commented

Yes I'm referring the the sides of the book. In my example they're from quests I made. You're able to test it by just typing apostrophes on each side in a quest description or something.

commented

Ah, sorry about that. What I meant to ask about was the right side of which menu. Was also misled by a recent issue to not realize you could normally change the quest task descriptions.
Now with fewer misunderstandings, I was able to reproduce it.
It's a bit more unusual than just apostrophes not showing up there. For that text box, apostrophes only render when there are an odd number of them, or if there are two in a row.

commented

Looks like this is caused by an issue in forge (MinecraftForge/MinecraftForge#7396). A workaround that can be implemented into HQM (PR coming up soon) would be to translate the task description using I18n instead of TranslatableComponent.
With the nature of this issue, similar problems are likely for translatable text in other parts of the mod. I'll do a search to see if I can spot any.

commented

After looking around and realizing that a I18n-workaround is not appropriate for all such potential issues, I no longer find it worthwhile to fix this for HQM's own translatable text.
Also, as I've come to realize that what should be raw text shouldn't go through the translation procedure to begin with (see formatting characters such as %), I'll get rid of the translation of the task description entirely for now.

Due to this, for when we try and add back support for translatable quest text properly (and not just for task descriptions), we should keep a clear distinction between raw text and translation keys.