Harvest with ease

Harvest with ease

19M Downloads

Add compatibility with Multitools.

meyverick opened this issue ยท 9 comments

commented

I have confirmed no other issue asks for this

  • I have searched for existing issues

Other mod

Multitools Enhanced

Current behavior

Not recognized as Hoe so it doesn't work.

Desired behavior

Recognized as Hoe.

Stacktrace and logs

No response

Additional context

No response

commented

What I can do is change slightly how the check for a hoe works, by allowing items with a specific tag to be recognized as hoes.

Once I'm done with that, you should open an issue with the other mod asking to add its items to that tag.

commented

I think that's a good way to allow other mods (not only Multitool) to be compatible with yours ๐Ÿ™‚ So it will requires 2 tags? One that say "I'm a hoe" and an other that say "I'm in diamond".

commented

The fact that it's diamond should be detected automatically. If it's made of a material not in the Vanilla game, there is a configuration option to define the tier list.

When I get to work on this, I'll also see if there are other things that might make sense define as tags and check whether the material of multitools is detected automatically.

commented

Thank you for your answers ๐Ÿ™‚

commented

Apparently, there is already a Vanilla tag for hoes. I just need to check for that too.

However, the material of multitools is not detected automatically as I thought it would.
Minecraft really made it hard to handle tiers since they, well, removed the concept of tiers altogether.
I'll see what I can do, but it might take longer than I thought.

commented

I also suggested to add compatibility to another mod and he seems to managed to do it. Perhaps it could help you: Enhance RightClickHarvest compatibility with Multitools. #88 ๐Ÿ™‚

commented

Thank you, but unfortunately our systems work differently.

My system is more customizable, but it's more complicated to handle.
Their system is less customizable, but easier to work with.

While for recognizing them as hoes was just an oversight on my part, the tool material is just a mess from Minecraft.
I want the end user to be able to configure exactly what tiers are there, in what order, and how much should each allow to multi-harvest, but I'm currently stuck with a configuration system that is not as expressive as I'd need it to be.

So, I either find a workaround, or I'll have to wait until I have enough time to finally develop my own configuration system.
I have very little time at the moment, but I'll try my best to be quick.

commented

Perhaps adding an option where we can add the item with its quality like:

{
  "hoes": [
      "itemId/quality",
      "enhancedmultitool:diamond_multitool/diamond"
  ]
}

End then, if the listed items contain the tag "hoe" (don't know how you detect it) then you support it.

commented

Yeah, but this is a solution that requires having fixed tiers, which is something I'd like yo avoid.

The other option to defining my own configuration system is to define a new data object, which is definitely faster.
It would then look something like this:

{
  "tier0": ["item1", "item2"],
  "tier1": ["item3", "item4", "item5"],
  ...
}

But even something like this doesn't really achieve what I want, so I'd have to think about it a bit more.