Hatchery

Hatchery

14M Downloads

Animal net doesn't get emptied when placing chicken in nesting pen.

Zeldon567 opened this issue ยท 18 comments

commented

If placed on the ground, the animal net is still named as if it has an animal in it and is no longer functional. Using it on nesting pens duplicates the chicken.

commented

GitHub noob here. How do I add a label?

commented

you cant add lable's only me. I need to know what mod version, minecraft version, and are you using spongeforge?

commented

Its Sponge.. they have broken my mod so many times. They fix it, than couple versions later its broken again.

commented

On 1.12.2, of course.

commented

Bah. Is there a version of Spongeforge that allows your mod to work correctly?

commented

Minecraft version 1.12.2, mod version v2.1.2, spongeforge is being run. FoamFix anarchy is in the pack.

commented

I have tested Chickens and Hatchery in a clean pack and can confirm it works as intended, Will investigate the source of the issue.

commented

Unfortunately nothing is appearing in the logs involving this issue. How irritating.

commented

I'll try removing FoamFix at some point and see if that fixes the issue.

commented

Removing FoamFix had no effect.

commented

no idea.. .tbh.

commented

I don't suppose it's something you could easily fix on your end and release an update, is it? Or you would've done it already.

commented

People playing my pack are having the same issue, using Forge.

Edit: NVM... it seems the people were using it on a server that was using spongeforge.... so there is no fix for this?

commented

no.. best thing to do is report to sponge forge. The only reason is because im using forge methods. Now im all ways willing to make changes if needed. but I normally don't fix sponge forge issues unless i know for sure it works in forge as intended

commented

We have updated to sponge several version already and still not fixed. On a side note; if you click on the floor to place a mob it will place one, when killed you can place another one and so on, infinite placement of captured mob. As you said in your last comment:

Now im all ways willing to make changes if needed. but I normally don't fix sponge forge issues unless i know for sure it works in forge as intended

Could you be so gracious as to make that change please? To also let @Zeldon567 know.
Thank you so much, we love your mod and quick responses.

Also on Sponge's Github for you to see if they have specific questions.
Thanks.

commented

I'm not entirely sure what to do to fix this. The Net contains an Entity NBT, when you click on the pen it places it into the pen, than it erases the NBT data. But whats happening is the NBT isn't throwing a null like it should. The code to remove the chicken is no different whether your placing in a pen or on the ground. So why one works and the other doesn't baffles me. But something interacting with blocks messes up the item.

commented

Problem is neither options clears the net.
Whether you place in pen or on ground net stays w/mob info and can be infi placed.

commented

I get that, but in my code it clears the net. Its a sponge interaction issue. It works fine in plain forge.

Also does not mean I wont look into another method to handle this. but I don't write for sponge only forge.