Killing with Sacrificial dagger/knife doesn't give hats
Chewypuppielover opened this issue · 2 comments
Killing Mobs with Blood Magic's Sacrificial dagger/knife doesn't give hats in 1.16 at least. I'm guessing it has to do with the type of damage it uses and so there might not be a fix.
I had a look at their source and Wot is setting the entity health to a
negative value and calling the onDeath method.
https://github.com/WayofTime/BloodMagic/blob/1.16.3/src/main/java/wayoftime/bloodmagic/common/item/ItemDaggerOfSacrifice.java#L67
Hats relies on Forge's death event trigger which ends up being bypassed by
the sacrificial dagger, so Hats doesn't even know an entity just died.
This issue might have to be addressed on their end to fire a
LivingDeathEvent when the dagger is used.
…On Sun, 21 Nov 2021, 9:36 am Suzy, ***@***.***> wrote:
Killing Mobs with Blood Magic's Sacrificial dagger/knife doesn't give hats
in 1.16 at least. I'm guessing it has to do with the type of damage it uses
and so there might not be a fix.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#232>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARRETBUQ3RWSSOZIOAJCBDUNBEINANCNFSM5IOSNF5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.