Hbm's Nuclear Tech Mod

Hbm's Nuclear Tech Mod

Mods
1M Downloads

Fibrosis status isn't saved across restarts

FavoritoHJS opened this issue · 12 comments

commented

Describe the bug

At least according to the code, there is no saving of Fibrosis to NBT, thus, no way to save it after a restart

Haven't done any testing yet, but opening up a level.dat made after 4018 should show the issue.

Hbm-s-Nuclear-Tech-GIT/src/main/java/com/hbm/extprop/HbmLivingProps.java

Lines 253 to 271 in 30765c5

public void saveNBTData(NBTTagCompound nbt) {
NBTTagCompound props = new NBTTagCompound();
props.setFloat("hfr_radiation", radiation);
props.setFloat("hfr_digamma", digamma);
props.setInteger("hfr_asbestos", asbestos);
props.setInteger("hfr_bomb", bombTimer);
props.setInteger("hfr_contagion", contagion);
props.setInteger("hfr_blacklung", blacklung);
props.setInteger("hfr_cont_count", this.contamination.size());
for(int i = 0; i < this.contamination.size(); i++) {
this.contamination.get(i).save(props, i);
}
nbt.setTag("HbmLivingProps", props);
}

Note the lack of hfr_fibrosis

PS: The Fibrosis variable is uppercase, while java variables should be lowercase.

Please solve this equation to x

(this didn't show up for some reason, thanks github)

x²+3x-19=√(9x²)+6
x^2+3x-19=|3x|+6 !! The goshdarned multiplication
x^2+3x-25=|3x|

|      /|  As you can see, my plan of finding the bottom point
|     / |  and calculating from there isn't going to work...
\    /  /
 |  /  |   Time to copy someone else's idea!
 \ /   /
  /    |
 /\   /
/  \_/
x^2+3x-25=-3x x^2+3x-25=3x
x^2-25=0 x^2+6x-25=0
sqrt(25)^2-25=0 x^2+6x-25=0
sqrt(25)=5 x+sqrt(6x)=5
. 3+sqrt(24)=Definitively Not Five
x is 5 oh god am I reinventing the quadratic formula

PS: How do you make a collapsing spoiler in GFM?

commented

ok, it looks like #311 does indeed fix this.
waiting for merge

this is not a desperate attempt to get chocolate, send help

commented

oh god i am not good with computer

commented

I didn't even think about the second solution when adding this requirement, so x=5 is perfectly acceptable.

commented

Serious with your second solution for x? 😱

commented

Update on the fix: 311 (and any future PRs) are waiting for 228 to get merged, aka a long, long time

I'm stopping PRs and any major changes until UFFR has finished merging his PR with the main branch, that way I'll avoid creating even more conflicts. Just be patient.

Originally posted by @HbmMods in #311 (comment)

(890 files changed and 200k lines of code!? that must be a record)
PS: Sorry for pang, didn't realize the @ existed.

commented

x = -3-√(34) also satisfies the equation. 😆

commented
commented

pretty much.

What is that for anyway? Human verification?

commented

It's mainly a test whether people manage to actually use the issue template or not, reminding them to use the github issue boards for issues and nothing else.

commented

Oh great, now my oversight will be immortalized for a while

commented

It is a real possibility that merging my PR would massively mess with UFFR's fork though, plus since he's already spent days working on it, it's fine

commented

Was fixed in X4054 when vær's PR was merged.