Hephaestus Fabric

Hephaestus Fabric

Mods
1M Downloads

Heater deletes fuels when there are fewer than 2 items

myriapoleis opened this issue ยท 1 comments

commented

Minecraft Version

1.20.1

Fabric Version

0.15.10

Fabric API Version

0.92.1

Hephaestus Version

3.6.4.273

Describe your issue

When a single piece of fuel is placed into a heater (the solid fuel option for melters and alloyers), the fuel disappears without adding furnace tick time to the smelting apparatus above it. I'd guess this is because it checks the burn time of the itemstack type after decreasing the number of items in the itemstack by 1... rearrange 2 lines of code...

Crash Report

No response

Other mods

None

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Searched closed issues

commented

The relevant code is here, I believe:

TinkersConstruct/src/main/java/slimeknights/tconstruct/smeltery/block/entity/module/FuelModule.java

Lines 172 to 174 in d6bb411

try (Transaction tx = TransferUtil.getTransaction()) {
view.extract(view.getResource(), 1, tx);
if (view.getResource().matches(stack) && !stack.isEmpty()) {