HerdsPanic

HerdsPanic

226k Downloads

Bug: Exclude list delimiter between mod id and mob id is actually dot and not colon

Goldenrevolver opened this issue ยท 2 comments

commented

the hint for the config setting mentions "modid:mobname". the code uses entity.getType().toString() which I was told returns minecraft:chicken for a chicken, yet you have the 'replace' call in there to cut out an "entity." infix, which implies that the return value was minecraft.entity.chicken.

I tested this both with an unmodified version of 1.0.6 on 1.19.2 and a version with my personal include list tweak mentioned in #3, both in my current mod list as well as a freshly created 'zero other mods' environment. I tested it mostly with vanilla mobs but also a bit with modded mobs. it's always consistent that it works as intended with a "." and doesn't with a ":".

so I think the exclude list seems to expect "modid.mobname" names. before posting this, I searched through your discord as well as looked at your other mod with an exclude list, https://github.com/Globox1997/RpgDifficulty .

on discord I found multiple reports of people reporting that exclude lists don't work and you recommending to use the ":" format (and then no one ever replying after you tried to help them which would make you think your advise worked or they gave up).

on github, I found Globox1997/RpgDifficulty#4 and Globox1997/RpgDifficulty#17 as well as the commit Globox1997/RpgDifficulty@a160f86 which mentions that it swapped from ":" to "." , but the commit doesn't really look like it changed that.

so is this bugged only in this mod or also in the other? and has this been bugged for a while or is this a recent change or am I doing something wrong?

commented

I know I'm a little late to the party, but if anyone else ends up here I'll answer the question:

I used the following for my test: "excludedEntity": ["minecraft:zombie","minecraft.skeleton"],

Skeleton's still scaled, Zombies did not. The Colon is the correct way to go. Tested in version 1.3.12.

commented

Fixed config delimiter with c69128b.