Bloodcasting doesn't round up

Question

Bloodcasting doesn't round up

yrsegal opened this issue 2 years ago · 4 comments

yrsegal commented 2 years ago

https://github.com/gamma-delta/HexMod/blob/main/Common/src/main/java/at/petrak/hexcasting/api/spell/casting/CastingHarness.kt#L544

This should have a ceil attached to it. Otherwise, small costs have trouble being bloodcast.

yrsegal · Answer 1 · 2022-11-29T17:38:40.000Z

oops, I didn't use a permalink...

https://github.com/gamma-delta/HexMod/blob/de8e84cdbd305836792ca456d95528c23c3f8c3d/Common/src/main/java/at/petrak/hexcasting/api/spell/casting/CastingHarness.kt#L545

this is the line that needed the ceil.

yrsegal · Answer 2 · 2022-11-29T17:42:50.000Z

This "fix" will allow free bloodcasting of any cost below half a heart, and should be reverted

yrsegal · Answer 3 · 2022-11-29T20:03:04.000Z

This still doesn't fix costs like 3.5, though. That'll just fail due to lack of media, even though it'll still take 3 health. I said ceil for a reason

gamma-delta · Answer 4 · 2022-11-29T21:10:43.000Z

No, it doesn't. I just checked.

Share to