[Bug?] Break Block does not call onBreak of broken blocks

Question

[Bug?] Break Block does not call onBreak of broken blocks

walksanatora opened this issue 10 months ago · 8 comments

walksanatora commented 10 months ago

so in Hexxy Dimensions I have a block that when broken checks the player and sends them back to the overworld
but break block does not pass that (or some other way my blocks onBreakBlock method is not being called

object-Object · Answer 1 · 2023-12-02T08:20:07.000Z

can you please provide the minimal steps/code necessary to reproduce the issue?

walksanatora · Answer 2 · 2023-12-03T05:05:49.000Z

made a block with

class TestBlock(set: Settings) : Block(set) {
    override fun onBreak(world: World, pos: BlockPos?, state: BlockState?, player: PlayerEntity) {
        super.onBreak(world, pos, state, player)
        println("world: %s\npos: %s\nstate: %s\nplayer: %s".format(
            world,pos,state,player
        ))
    }
}

when I break with my fist the world,pos,state,player are printed to console
when I break with BreakBlock it fails

also also checked with /setblock and /fill and same effect occurs (no output)

object-Object · Answer 3 · 2024-01-11T02:02:42.000Z

Please post all of the relevant versions (game, modloader, hex, etc) and the modlist.

walksanatora · Answer 4 · 2024-01-19T03:55:26.000Z

1.20.1, fabric, hexcasting 0.11.1-7-pre-609,
patchouli 1.20.1-84
paucal 0.6.0-pre-118
cloth config 11.1.118
cardinal componenets api 5.2.1
hexxy-dimensions 1.2.1

this could probally be fixed with a

if (env.caster is ServerPlayer) {
    blockstate.block.onBreak(env.world,pos,blockstate,env.caster
}

after the call to env.world.destroyBlock

Talia-12 · Answer 5 · 2024-02-05T13:41:02.000Z

onBreak (named playerWillDestroy in the mojMap) seems to be specifically for when players break blocks, triggering things like piglin getting angry, ensuring shulker boxes are still dropped if the player is in creative, etc. I think it would break things elsewhere to add this call (example: if the player casts break block in creative shulker boxes will drop twice, once from the playerWillDestroy call and once from the normal loot drop method).

walksanatora · Answer 6 · 2024-02-05T16:03:07.000Z

then perhaps some sort of interface for HexcastingBreakAware so you can make a block aware of onBreak manually

walksanatora · Answer 7 · 2024-02-05T16:07:11.000Z

idea for HexcastingBreakAware intereface would be:

interface HexcastingBreakAwareBlock {
     void onHexcastingBreak(CastingEnvironment env, BlockPos pos, BlockState state)
}

object-Object · Answer 8 · 2024-06-14T22:43:47.000Z

For comparison, this is how Psi does it: https://github.com/VazkiiMods/Psi/blob/3f9806bcb00caf1a17a24f2052161649d4d4a33c/src/main/java/vazkii/psi/common/spell/trick/block/PieceTrickBreakBlock.java#L106-L111

Alternatively, here's how net.minecraft.server.level.ServerPlayerGameMode#destroyBlock works - maybe we could do something similar?

    public boolean destroyBlock(BlockPos pos) {
        BlockState blockState = this.level.getBlockState(pos);
        if (!this.player.getMainHandItem().getItem().canAttackBlock(blockState, this.level, pos, this.player)) {
            return false;
        } else {
            BlockEntity blockEntity = this.level.getBlockEntity(pos);
            Block block = blockState.getBlock();
            if (block instanceof GameMasterBlock && !this.player.canUseGameMasterBlocks()) {
                this.level.sendBlockUpdated(pos, blockState, blockState, 3);
                return false;
            } else if (this.player.blockActionRestricted(this.level, pos, this.gameModeForPlayer)) {
                return false;
            } else {
                block.playerWillDestroy(this.level, pos, blockState, this.player);
                boolean bl = this.level.removeBlock(pos, false);
                if (bl) {
                    block.destroy(this.level, pos, blockState);
                }

                if (this.isCreative()) {
                    return true;
                } else {
                    ItemStack itemStack = this.player.getMainHandItem();
                    ItemStack itemStack2 = itemStack.copy();
                    boolean bl2 = this.player.hasCorrectToolForDrops(blockState);
                    itemStack.mineBlock(this.level, blockState, pos, this.player);
                    if (bl && bl2) {
                        block.playerDestroy(this.level, this.player, pos, blockState, blockEntity, itemStack2);
                    }

                    return true;
                }
            }
        }
    }

Share to