1.20 staffcasting can draw from casting items

Question

1.20 staffcasting can draw from casting items

moonlol opened this issue 8 months ago · 3 comments

moonlol commented 8 months ago

hexcasting-forge-1.20.1-0.11.1-7-pre-607

staff casting with casting items in inventory causes them to be used as media sources, prioritized over standard forms of media too it appears

moonlol · Answer 1 · 2024-01-12T20:06:14.000Z

Casting items as in cyphers/trinkets/artifacts?

yep sorry for not being clear, i noticed this specifically with artifacts and trinkets, havent tried cyphers

makes make phial obsolete i suppose if you want to cheese

object-Object · Answer 2 · 2024-01-12T20:05:09.000Z

Casting items as in cyphers/trinkets/artifacts?

walksanatora · Answer 3 · 2024-01-23T19:48:26.000Z

looked into it a bit.
it is cause all three of these extend ItemMediaHolder which extends MediaHolderItem which implements MediaHolderItem
which then gets the component/capability attached to them meaning that they get their media consumed but canProvideMedia is set to false... but that is not respected in MediaHelper#scanPlayerForMediaStuff or mabey the check for canProvideMedia should perhaps be checked in PlayerBasedCastEnv#extractMediaFromInventory

Share to