Hex Casting

Hex Casting

6M Downloads

Spell Circle Unable to use Recharge

eleksploded opened this issue ยท 3 comments

commented

Modloader

Forge

Minecraft version

1.20.1

Hex Casting version

0.11.1-7-pre-629

Modloader version

Forge 47.2.0

Modpack info

Custom made pack.

The latest.log file

https://mclo.gs/B2HZ1IO

Issue description

Spell circles are unable to use the recharge hex to recharge a phial in a players offhand.

2024-03-20_23 20 44
2024-03-20_23 42 33

Steps to reproduce

Create a Spell circle that grabs amethyst in its bounds in zone distillation, and uses thoth's to cast recharge with each of them. It will fail saying a rechargeable item is needed in your other hand, even if you are holding an empty phial (no matter which hand or whats in the other hand).

Other information

No response

commented

Ok so I decided to go through and figure out why. OpRecharge calls getHeldItemToOperateOn which uses getPrimaryStacks. However in the Circle's casting environment, getPrimaryStacks always returns an empty list, so no matter what the caster is holding, the spell circle will never be able to access it.

commented

thanks for looking into it!
@Talia-12 any thoughts on this issue? I see you left a TODO about using adjacent inventories - is that still planned?

commented

I implemented it with adjacent inventories and presented it, petra said she was planning on doing it with a specific in-circle component (like a directrix but stores items), so the adjacent inventories version didn't get merged in