Hex Casting

Hex Casting

6M Downloads

Debug media cube is broken in pre-620

Twisted-Code opened this issue ยท 10 comments

commented

Modloader

Fabric

Minecraft version

1.20.1

Hex Casting version

0.11.1-7-pre-620

Modloader version

Fabric: 0.1|.6 + API 0.91.0+ 1.20.1

Modpack info

https://github.com/walksanatora/HexxyTestPack

The latest.log file

https://mclo.gs/nvZYHdD

Issue description

Despite my expectation, having a media cube renamed to "debug patterns" does not seem to do anything.

Steps to reproduce

  1. Load a creative world
  2. spawn a media cube
  3. rename the media cube "Debug Patterns" (any capitalization, last I checked, should work)
  4. draw some patterns
  5. nothing appears in chat, unlike on 1.19.2

Other information

2024-03-26_08 10 52

commented

the name I gave the media cube was enough for it to start doing the enchanted glow effect, so I must've done something right. It's just not working completely?

commented

@macks2008 Can you check if "debug media" works?

Probably related:

public static final String DISPLAY_PATTERNS = "patterns";

I don't see any usages of this variable. Guessing it got accidentally refactored into the void at some point.

commented

what is debug media supposed to do? it didn't seem to do anything when I drew ol' Ray Caste
image

commented

make sure you're using it in survival - it's supposed to print all media usage drawn from the cube, so being in creative or having other sources messes with it

commented

great, thanks for confirming. I think it should be an easy fix then - hopefully just re-add the code that was removed. prioritizing as medium because hex is hard enough to use even without the limited debug features being broken.

commented

๐Ÿฅณ

commented

Okay it does work in survival. So it's just debug patterns that's not working, as far as I can tell.

commented

I removed the code while I was refactoring the evaluator because I didn't actually know it was there (Wire added it without telling me) so I didn't know how it worked.

commented

ah... whoops. That reminds me of a joke about code documentation, "when I wrote this code, only God and I knew what it did. Now only God knows". (Side note: what is Wire? Is that an IDE or gradle plugin or something?)
Anyway, just wanted to check in: Has any progress been made to fix this? I was starting to set up my development world for "HexxyTest S2" and noticed this feature isn't yet fixed on whatever version we are using.

commented

wiresegal, former hex contributor
afaik no progress has been made; we'll close this issue when it's fixed on main