Mishap message with format placeholders fail to display in Chinese
YukkuriC opened this issue · 9 comments
Modloader
Forge
Minecraft version
1.20.1
Hex Casting version
0.11.2
Modloader version
Forge 47.3.6
Modpack info
No response
The latest.log file
No response
Issue description
as the images show, all placeholders are left as placeholders, not rendering what they should be.
Steps to reproduce
- switch language to Simplified Chinese
- do a mishap with arg(s)
Other information
not sure if it's relevant, but zh_cn.json has been transformed from direct UTF-8 text into escaped \uxxxx codes for every non-ascii characters, which is not readable either :(
Which mishaps are shown in the images?
first MishapBadOffhandItem and second MishapInvalidIota
I didn't notice there's an i18n resourcepack which polluted the translations sry _(:з」∠)_
if it's the main cause then this issue could be closed I guess?
cc @ChuijkYahus
Got it, would be doing tests in a few hours.
Unicode conversion isn't flawed though.
From what has been shown in the images, it's very likely that the localization comes from CFPAOrg/Minecraft-Mod-Language-Package.
In the repo's packer policies, by default, resourcepacks for newer Minecraft versions would take translations for older versions as a fallback. In Hex Casting's case, since I directly stuffed not-supported json5 into project/1.20, the translation file actually getting packed is that for 1.18, which takes spell names in mishap keys directly.
This explains there being an extra placeholder in both images. And because I haven't posted translations to other distribution sources, this is probably the case.
Could be solved by removing translation resoucepack as of now.
I would also try to solve this by excluding related directories in package policies there. This would require a fix PR on CFPAOrg's side, and should take effect the day after it getting merged.
If not so after PR's merged, delete the resourcepack and letting downloader mod download a new one (with the downloader mod installed), or download a new pack on the official website in their README.
Need to check what the resourcepack for 1.20 looks like. I would be posting links to fix PR after I return to my machine.
tl;dr: Got lazy and thrown json5 there and it wasn't packed, so older versions took its place. This problem is most likely not on HexMod's side.
Though have to add a bit more, there wasn't a file for newer versions there at the time of opening this issue, so not actually caused by json5, but the default fallback mechanism.