Hex Casting

Hex Casting

Mods
7M Downloads

Using Reveal with an unbound cleric circle causes NullPointerException

Robotgiggle opened this issue ยท 1 comments

commented

Modloader

Forge, Fabric

Minecraft version

1.20.1

Hex Casting version

0.11.2

Issue description

When an unbound cleric circle tries to use Reveal, the slate produces mishap particles but the circle does not stop, and no mishap is displayed when looking at the impetus with a scrying lens. At the same time, this pops up in the log:
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_3222.method_43496(net.minecraft.class_2561)" because the return value of "at.petrak.hexcasting.common.blocks.circles.impetuses.BlockEntityRedstoneImpetus.getStoredPlayer()" is null

Seems like Reveal needs a player to reveal to, and there's no special handling for an unbound cleric circle trying to cast it.

Steps to reproduce

  1. Create a spell circle that pushes any iota and then casts Reveal
  2. Add an unbound cleric impetus
  3. Run the circle
  4. Observe mishap particles on the reveal slate, and the error message in the log
commented

Looked into fixing this but was unable to replicate it, even with a non-dev build of hexcasting. May have been caused by some kind of addon interaction that messes with circle environments? Either way, closing for now.