Modloader

Fabric

Minecraft version

1.20.1

Hex Casting version

0.11.2

Modloader version

Fabric: Loader 0.17.2 + API 0.92.6

Modpack info

I am playing a modpack I personally cobbled together, I am attempting to upload it to modrinth but it is still under review. In the meantime, this is a dropbox link to the .mrpack file. https://www.dropbox.com/scl/fi/sigxf1iqi5clky7jweqmz/Spectrum-Plus-Plus-1.20.1-1.2.2.mrpack?rlkey=35hetkfjvh2h98q1q1lcsev4o&st=m20u7xda&dl=0

The latest.log file

https://mclo.gs/56c03Vj

Issue description

Often when loading new chunks the game will freeze and then crash, leading to the player data being reset, but not the world data, this is extremely frustrating as it has deleted several of my items.

This line;
"at knot/at.petrak.hexcasting.common.loot.AddPerWorldPatternToScrollFunc.doStatic(AddPerWorldPatternToScrollFunc.java:52)" seems to imply to me that it has something to do with rendering the great spell patterns on ancient scrolls, but I'm extremely bad at coding and/or reading code, so I don't know for certain.

I am currently using one (1) add-on for hexcasting, that being Hexical, and had several including a Hexal version that I was directed to by the discord. The crashes started after I added these, but I have turned them off and the crashes have not stopped.

Steps to reproduce

!. Open the game.
2. Load new chunks.
3. Game crashes.

Other information

Not sure what to put here, just hope there's a solution to this!

does it still happen if you run /hexcasting recalcPatterns ?

This seems to have done the trick, thank you so much!

The problematic line seems to be here - specifically, getCanonicalStrokesPerWorld can return null:

I think we could fix the crash by just logging an error (ideally including something like "try running recalcPatterns") and returning an empty stack if pat is null.