HoloInventory

HoloInventory

1M Downloads

doRenderHologram crash if itemStack = null

Caellian opened this issue · 2 comments

commented

You don't have a null check on doRenderHologram inside net.dries007.holoInventory.client.Renderer.

Not sure if it's a problem or not, but guy on Minecraft Forums crashed because of
null pointer. (Crash log: http://pastebin.com/PD4pXz4Z)

I ran through Renderer file and you're directly sending ItemStack from renderHologram to doRenderHologram. (Crash occurs inside renderHologram)

commented

OK. You make nice bugreports!
Op 10-jan.-2014 06:14 schreef "Feronzed" [email protected]:

You don't have a null check on doRenderHologram inside
net.dries007.holoInventory.client.Renderer.

Not sure if it's a problem or not, but guy on Minecraft Forums crashed
because of
null pointer. (Crash log: http://pastebin.com/PD4pXz4Z)

I ran through Renderer file and you're directly sending ItemStack from
renderHologram to doRenderHologram. (Crash occurs inside renderHologram)


Reply to this email directly or view it on GitHubhttps://github.com//issues/3
.

commented

Normally, the itemstack can't ever be null there as that is checked on the server before the inventory is send to the client. But I added some extra anti NPE checking anyways.