Fix event handlers (like PlayerInteractEvent) not respecting current event state
squeek502 opened this issue · 4 comments
Right now, for many event handlers in HO, the relevant states of the event (isCanceled(), getResult()) is not checked before the logic is executed. This decreases compatibility with other mods significantly.
Would fix ForgeEssentials/ForgeEssentials#1966
@cap10zeus Are you using ForgeEssentials? If so, eating food and then it reappearing in your inventory is usually because the player doesn't have FE Perms to "use" the food "item". So, you eat it (client-side)… the server says "Nope, no perms"… and then the server puts it back in your inventory, and you didn't gain the hunger.
Can't say for sure. That would be a server/client desync, but can't be certain of the cause.
Hmm, that makes sense. We don't have ForgeEssentials but we do have Thermos+ GriefPreventionPlus. It was doing it for awhile then it stopped, so it's just annoying that I can't figure out the cause. I will keep an eye on the perms though. Thanks for the advice. Oh and hi there PitchBright, we've crossed a few times now, lol.