Hunger Overhaul

Hunger Overhaul

Mods
9M Downloads

[Crash] Ticking player when using Rod of the Skies from Botania

HCSarise opened this issue ยท 2 comments

commented

Hi,

I get the following crash after using Rod of the Skies from Botania: http://pastebin.com/vdB174DN

Vazkii pointed me in your direction for this.

commented

I was right in my suspicion. The correct way to stop an item in use:

player.stopUsingItem()

I'll still add some code to avoid the crash on HO's end, but it should also be fixed by Botania.

commented

I'd have to look at it more, but this line strikes me as odd. Unsure if that's the correct way to cancel an item being used (as it triggers the Forge event PlayerUseItemEvent.Start, which is what HO is using; HO assumes that the ItemStack is non-null, which seems like a pretty reasonable assumption to me).

It'd be easy for us to fix, but it seems like the null ItemStack being sent to PlayerUseItemEvent.Start could easily cause problems in other mods.

@Vazkii?