Hwyla

Hwyla

86M Downloads

Lang files don't fully work

MrNinja93 opened this issue · 8 comments

commented

Just an FYI was just testing out Spanish lang file and found the translations aren't taking effect in a few places one being the "modules" and subsequent screens Just in-case it was my derping I checked the original included French and Russian languages and they both have the same issue

French
2016-11-11_06 54 49

Edit: French isn't fully translated but some of that page is.

Custom Spanish
2016-11-11_06 59 43

commented

Is this for the option titles? Like Jukebox disk?

commented

Yep the options. etc for the screenshots its the vanilla one, from the French file lines 117-123

option.vanilla.spawntype=Spawner type
option.vanilla.growthvalue=Niveau de croissance
option.vanilla.leverstate=Etat Levier
option.vanilla.repeater=Répeteur retard
option.vanilla.comparator=Comparateur mode
option.vanilla.redstone=Redstone puissance
option.vanilla.jukebox=Jukebox disque

Edit: Also the back button in the modules "home screen" isn't changing from English (every other "back" button changes though I think)

commented

Oh boy, the GUI widget system... This'll be a nice fun jump down the rabbit hole...

commented

Oh boy, the GUI widget system... This'll be a nice fun jump down the rabbit hole...

Fun isn't what comes to mind when I looked at those files.... Good luck!

commented

To save opening another issue when it's somewhat related.

In the lang files if something can't be translated do you want it be included in the lang file in English or that line be deleted (Some current files are including some are deleting, "Metadata" being one but also "%s" "Vanilla" "Waila" etc) Better to check than make an assumption and be wrong.

commented

Remove the line. Lang files are loaded in "layers" with en_US at the bottom.

commented

So I went to test an incoming PR and I found some extra info for this issue. The lang files take effect in the "modules" screens only after a restart of the game after you've changed language, everything else is an instant sync (Though the one "back" button never changes- See screenshot)

2016-11-11_23 56 24
)

commented

This should be fixed when I finish #22