IC2 Classic

IC2 Classic

2M Downloads

[1.19.2] Industrial workbench breaking

howdoidownloadfile opened this issue ยท 6 comments

commented

Industrial workbench breaks while filling inventory with non stackable items while its storage is full and corrupts all connected expansions, so workbench won't do anything and won't send chat reports. Connected expansions won't interact with new placed workbenches or will insta break them. Restarting world or server didn't fix anything, so the only solution i've got is replacing whole structure (on the same place if you want).

Untitled.mp4

And sorry for my english

commented

Eh where do you get the iridium or the Diamonds from?

commented

Eh where do you get the iridium or the Diamonds from?

from filled connected uu expansion, but the point is that it isnt even indicating about subcrafting/having recipe for those, its just doesnt do anything with any craft

commented

@howdoidownloadfile yeah, but i need the whole context to understand why this may happen otherwise i have a lot of ? that can lead to hundreds of potential reasons and that doesn't help in the fixing.
That's why i asked.

This is just a slight request, which you don't have to do, but that would make my work easier.
Could you try making it reproducible without the UUMatter expansion?
And if you get it reproduced if you could try it without the memory expansion?
Or is this combo required?

commented

If I may add:
How to reproduce:

  1. Place down the Worktable.
  2. Encode some unstackable item recipe (Iron Rotor)
  3. Fill up your inventory with items and leave some space for rotors to go
    Image
    You can click to craft them as long as you wish, but as soon as you add the UUExpansion (even without any items set), you won't be able to craft them and you get this in the logs:
[22:39:49] [Server thread/ERROR] [minecraft/PacketUtils]: Failed to handle packet net.minecraft.network.protocol.game.ServerboundContainerClickPacket@187d1d1c, suppressing error
java.lang.IllegalStateException: Snapshot already present
	at ic2.core.block.base.tiles.impls.BaseExpansionTileEntity.setSnapshot(BaseExpansionTileEntity.java:84) ~[IC2Classic-1.19.2-2.1.2.1.jar%23155!/:1.19.2-2.1.2.1] {re:classloading}
	at ic2.core.block.machines.tiles.nv.IndustrialWorkbenchTileEntity.putSnapshot(IndustrialWorkbenchTileEntity.java:473) ~[IC2Classic-1.19.2-2.1.2.1.jar%23155!/:1.19.2-2.1.2.1] {re:classloading}
	at ic2.core.block.machines.containers.nv.IndustrialWorkbenchContainer.m_150399_(IndustrialWorkbenchContainer.java:246) ~[IC2Classic-1.19.2-2.1.2.1.jar%23155!/:1.19.2-2.1.2.1] {re:classloading}
	at net.minecraft.server.network.ServerGamePacketListenerImpl.m_5914_(ServerGamePacketListenerImpl.java:1636) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:mixin,re:classloading,pl:mixin:APP:ic2.mixins.json:server.PlayerNetMixin,pl:mixin:A}
	at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.m_5797_(ServerboundContainerClickPacket.java:56) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:classloading}
	at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.m_5797_(ServerboundContainerClickPacket.java:12) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:classloading}
	at net.minecraft.network.protocol.PacketUtils.m_131356_(PacketUtils.java:22) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:classloading}
	at net.minecraft.server.TickTask.run(TickTask.java:18) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:classloading}
	at net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:157) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:classloading}
	at net.minecraft.server.MinecraftServer.m_6367_(MinecraftServer.java:763) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_6367_(MinecraftServer.java:157) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:131) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_129961_(MinecraftServer.java:746) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_7245_(MinecraftServer.java:740) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at net.minecraft.util.thread.BlockableEventLoop.m_18701_(BlockableEventLoop.java:140) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_130012_(MinecraftServer.java:726) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:658) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:244) ~[client-1.19.2-20220805.130853-srg.jar%23157!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:840) [?:?] {}

This is the minimal setup:

Image

Might be related to: #1245

commented

yeah was about report uum expansion, it bugging setup even if worktable inventory already has items for craft

commented

ok thank you. That should help a lot!