IC2 Classic

IC2 Classic

2M Downloads

ElectricItemManager should do it's internal calls via ElectricItem.manager, not directly

bdew opened this issue ยท 0 comments

commented

I've got a bug report in my mod Gendustry about an error that happens only with Classic, not Experimental - bdew-minecraft/gendustry#225

The problem is that my item manager delegates some calls to ElectricItem.rawManager

https://github.com/bdew/gendustry/blob/mc1.10.2/src/net/bdew/gendustry/power/ItemPoweredEUManager.scala#L36-L44

Which the IC2 API says is ok:

  • @note If you're implementing your own variant (ISpecialElectricItem), you can delegate to the
  • default implementations through ElectricItem.rawManager. The default implementation is designed
  • to minimize its dependency on its own constraints/structure and delegates most work back to the
  • more atomic features in the gateway manager.

However with Classic it doesn't work because your manager does the underlying calls directly and not via the gateway manager, e.g. in getCharge it's calling it's own discharge instead of ElectricItem.manager.discharge (the way experimental does it).