Memory Leak on Renderer
notfood opened this issue · 7 comments
There is a memory leak in the renderer whenever IChunUtil is installed.
Hit this issue with CustomNPC mod but it affects other mods as well. Grimoire of Gaia is another mod affected. The setup to reproduce is simple, just line the mods and wait. The more mobs, the more ram is leaked.
This issue happens under Windows and Linux, I couldn't test on Mac.
Enviroment used for test:
Linux 4.18.3 ArchLinux
Java 8.181
Minecraft 1.12.2
Forge 1.12.2-14.23.4.2756
iChunUtil 1.12.2-7.1.4
CustomNPCs 1.12.2 (09jul18)
Recorded for reference:
There is no ram ramp up here, no matter how long you wait.
With iChunUtil added:
There is a 20mb/s ramp up of ram usage here, eventually it runs out of memory and will crash to desktop. I speed it up so it's noticeable.
Same issue.
iChunUtil-1.12.2-7.1.4
CustomNPCs 1.12.2(26aug18)
No other mods installed.
Forge 14.23.5.2768
MC 1.12.2
Java 1.8.0_191
What precisely does it take to trigger this issue? I have had ichunutil and moreplayermodels installed in my pack for months and haven't experienced this memory issue (or at least not to the extent above). I've been able to play for hours on end with 8GB of ram allocated, and most of that is already in use from the get-go.
The issue is triggered by having iChunUtil and Custom NPCs. I haven't tried it with More Player Models. Then to start the leak, you simply spawn in an NPC.
Can confirm. It's somehow leaking outside of heap space, so you cannot protect yourself with -xmx command line parameters. I had 32 GB ram, and I went to lunch, and came back to find it had all filled up and spilled over into swap space.
Good news, I've spoken to Noppes and he's identified the issue on his end. It should be fixed in his mods from the next release.