Using a clay bucket with lava in on a magmatic dynamo from TE doesn't destroy the bucket

Can't confirm, bucket is getting destroyed accordingly.

What versions are you using?
I'm using the latest of
CoFHCore
IguanaTinkerTweaks
Mantle
TConstruct
ThermalExpansion
ThermalFoundation

I've tested it with clean configs too...
There's definitely something making this happen

@bonii-xx can confirm this. This still happens on latest versions... I've also saw reports about it somewhere else... reopen?

To elaborate, that seems to happen because TE seems to have changed how their tanks do stuff. The callbacks are not even getting called. Has to be fixed on their side.

@KingLemming

What callbacks are you talking about boni?

EntityInteractEvent (not needed for this though) and OnItemRightClick (https://github.com/SlimeKnights/IguanaTweaksTConstruct/blob/master/src/main/java/iguanaman/iguanatweakstconstruct/claybuckets/items/ClayBucket.java#L44). The tanks handle the liquid stuff themselves, so the bucket actually has no say in it at all. I'm surprised the clay buckets work correctly without it.

onItemRightClick() will only fire when you don't interact with a block, it's the last thing in the logic chain after onItemUseFirst() and onItemUse(). onItemUse() and onItemRightClick() only get called if the block that you click on does not do something.

That's not us doing it though, that's Minecraft. There isn't a single tile tank implementation that should have to call any of those functions.

https://github.com/CoFH/CoFHLib/blob/master/src/main/java/cofh/lib/util/helpers/FluidHelper.java#L162

is the code in question, if you're curious. That's pretty standard for fillable tiles.