Mining level boost modifier hardcoded

Question

Mining level boost modifier hardcoded

Adaptivity opened this issue 10 years ago · 9 comments

Adaptivity commented 10 years ago

Move it in .lang file.

Adaptivity · Answer 1 · 2014-09-24T07:30:01.000Z

Oh, they already in. How I missed this?

Adaptivity · Answer 2 · 2014-09-24T07:38:56.000Z

But this one hardcoded 😄

bonii-xx · Answer 3 · 2014-09-24T10:05:24.000Z

It uses the display name of the item (modhead). That should be localized? :I

Adaptivity · Answer 4 · 2014-09-24T11:54:40.000Z

I'm talking about this: http://i.imgur.com/PMRWLhh.jpg
In code: ModMiningLevelBoost.java line 15 I guess.

Adaptivity · Answer 5 · 2014-10-07T16:58:14.000Z

@bonii-xx Can you take a look?

bonii-xx · Answer 6 · 2014-10-07T19:18:53.000Z

No I can't make that translatable for the same reason it's not translatable in Tinkers itself. Because the implementation is derp.

Adaptivity · Answer 7 · 2015-01-02T10:48:36.000Z

So, is there are anyway to rewrite modifiers so they can use localization? Tried to use StatCollector but yeah it doesn't work 😄

bonii-xx · Answer 8 · 2015-01-02T11:45:33.000Z

The problem is that those strings are sometimes also used as data-values in NBT. Separating those 2 applications would require some changes to the modifiers, which might cause incompatibilities, which is why I'm likely gonna leave them as is. ;)

Adaptivity · Answer 9 · 2015-01-02T11:55:07.000Z

Might cause incompatibilities? Can we just try to localize them? In experimental branch for example. I really want finally translate all the Tinkers Construct.

Share to