ImmediatelyFast

ImmediatelyFast

42M Downloads

Use more accessor mixins then accesswideners

mrjasonn opened this issue ยท 5 comments

commented

Seems like a good change

commented

I don't see why this would be a good change. Accessors just adds more interface classes to the project for no benefit. Accessor mixins are also slightly worse performing during runtime than access wideners.

commented

I don't see why this would be a good change. Accessors just adds more interface classes to the project for no benefit. Accessor mixins are also slightly worse performing during runtime than access wideners.

@RaphiMC Hey, please read this, it gives some information about why accessor mixins would be better, in cases such as safety.

commented

I don't see why this would be a good change. Accessors just adds more interface classes to the project for no benefit. Accessor mixins are also slightly worse performing during runtime than access wideners.

@RaphiMC Hey, please read this, it gives some information about why accessor mixins would be better, in cases such as safety.

I glanced over it and couldn't find any good/applicable reasons why I should switch to mixin accessors.

commented

I doubt accessor mixins are less performant to be honest, but I personally see no reason to switch.

commented

I doubt accessor mixins are less performant to be honest, but I personally see no reason to switch.

The JVM most likely optimizes the casts and method invocations, but it still makes the code look uglier for no benefit