Immersive Engineering

Immersive Engineering

134M Downloads

updateMasterBlock performance issues

Sir-Will opened this issue ยท 4 comments

commented

ImmersiveEngineering-0.12-82


commented

No version numbers, no modlist, no debug crash, no test setup.

I'll just close this then, since you ignored the contribution guidelines in their entirety.

commented

Oh yea because it's not clear that markDirty is causing the performance issues.

commented

markDirty is a vanilla function.

All you've provided is a screenshot without any info on reproduction, without even putting any friggin text in your issue. That's not how you report issues, that's just how you annoy devs.

commented

It's on a server so there are like thousands of immersive engineering tile entities scattered around the map. There is no simple way to reproduce this issue.

Just because it's a vanilla function doesn't mean it will not cause performance issue. All I'm asking is if you can take a look at your code and see if you can reduce the amount of markDirty calls. Right now it looks like it does call markDirty every time it receives energy and on update, this can probably be changed to only call markDirty if there is a big data difference