Immersive Engineering

Immersive Engineering

Mods
134M Downloads

[1.12.2] v83 Skyhook Crashing and Wire Attaching Bugs

acook opened this issue · 2 comments

commented

While testing what I thought was a minor bug in skyhook attachments in a dedicated Forge-and-IE-only instance MC actually crashed while using the skyhook!

This crash is reproducible in singleplayer. It happens consistently when I create a new world (superflat or otherwise), add some steel posts, structural connectors, and steel wires then try to attach with a skyhook to a wire.

In 82 and for several previous versions the Skyhook was able to attach to a wire at any point. As of 83 you can only attach near a connector and it is not reliable.

In multiplayer it just doesn't connect except rarely when nearly touching the structural connector (but not necessarily looking right at it, it's very finicky).

Versions & Modlist

IE 83 and Forge 14.23.4.2705 used in both the plain IE testing instance as well as the modpack below.

Modpack

Here is the modpack information, I used a manually triggered debug crash and VanillaFix to generate this information:
https://paste.dimdev.org/vejakaboci.mccrash

Logs

Multiplayer Server: Modpack

Here is the output of my server logs (truncated) running the above modpack: https://gist.github.com/acook/844e17e4b3cff2b42a4d288db4de4632

Singleplayer: Vanilla + Forge + IE

In an instance with only IE (and Forge - same versions as above) I observed the following crash while trying to use the skyhook on a brand new world:
https://paste.ee/p/LD1sT

commented

I know what's causing the crash, I keep thinking the arguments for MathHelper.clamp are min, num, max while they are num, min, max. I'll have to look into the attaching issues, they might be caused by the same bug or they might be caused by something completely different.

commented

Your version makes sense to me in a very declarative way -1 < x < 1. 😄

The server spam was the product of failed attaching (the messages happened only when we were trying to use the skyhooks) but I found it interesting that it wasn't crashing. Possibly due to VanillaFix or some other difference in the dedicated server from the singleplayer instance, either way I'm just glad it didn't take down the server.