[1.12.2] Strange Interaction between Immersive Engineering, Pam's Harvestcraft and Astral Sorcery
Eresorm opened this issue ยท 17 comments
With all three mods installed the Assembler Multiblock can't craft some Pam's recipes. It shows the recipe but doesn't output anything. Without Astral Sorcery installed everything works as expected.
I have reported this on the AS Github already. #HellFirePvP/AstralSorcery#816
Handcrafting the recipes works in any case.
From my testing it seems that only recipes that use things like the Pot are affected, but only if they also output a Pam's items.
Used mods:
- IE: 0.12-84
- Pams: 1.12.2u
- AS: 1.12.2-1.9.3
And the previous Version of each mod respectively
Forge Versions: - 14.23.4.2705
- 14.23.4.2729
- 14.23.4.2739
I know this was last commented on over a year ago, but was it closed because it was fixed or because it won't be fixed?
I have found that updating to Immersive Engineering version 0.12-87 fixed these issues for me.
Updating IE to 0.12-87 didn't fix the issue for me.
IE: 0.12-87
Pams: 1.12.2za
AS: 1.12.2-1.10.3
Astral Sorcery developer said that their mod doesn't alter the crafting stuff there.
From what I can see, it happens if recipe has any of the following Pam's items: Mortar and Pestle, Juicer, Saucepan, Pot, Mixing Bowl, Bakeware, Skillet, Cutting Board. So basically this happens, if item is used in the recipe but not consumed and just stays in the crafting window unchanged after crafting is finished, unlike food ingredients or a bucket of water.
I tried to remove Astral Sorcery and Assembler worked as it should.
Forced crashlog: https://pastebin.com/Ti46bhCb
Can you append more details please? Or pastebin a forced crashlog ( hold f3 + c until the game crashes ... While ingame, not in the menu)
I did some digging and the reason why Pam's cooking utensils don't work in assembly recipes is that Astral Sorcery adds an NBT record to them for some reason.
So here is the serialized NBT for Mortar and Pestle.
recipeQuery.query (ItemStack):
{id:"harvestcraft:mortarandpestleitem",Count:1b,Damage:0s}
And here is the actual ItemStack in the assembly inventory:
{ForgeCaps:{"astralsorcery:cap_item_amulet_holder":{}},id:"harvestcraft:mortarandpestleitem",Count:1b,Damage:0s}
The record is added, because it's a non stackable item. It's the cleanest method to grab all equipables, without having to maintain a completely separate list or config file containing all of the potential equipped items that might be impacted by the amulet. I did point this out 5 months ago.
Yes, the issue actually came back for me as well.
I've been digging in the source code and find the problem seems to be related to this line .
Replacing it with just a dumb "return true" makes it go away, but I'm sure that introduces new bugs. This also happens to fix the Custom NPCs issue.
Does anyone know what the ItemStack.areCapsCompatible()
function does? I haven't been able to find documentation on it.
If I understand correctly, something is just wrong with ItemStacks from Recipe. For some reason, Assembler retrieves items from a recipe, but they don't have this specific NBT record. Because of this, assembler thinks that items don't match.
So it sounds like this is just a check to see what operations can be done with an item. I bet Custom NPCs is doing something similar. Is this not important to crafting? If so, we could just make a different NBT check for the assembler that ignores this part.
I created a pull request that fixes this issue (although I'm still pretty sure that it's AS problem). If you'll find a better way, let me know.
I'm still having this issue in ATM 3. Running AS 1.10.20, IE 0.12-92 and PH 1.12.2zf. Is there any hope of a fix in the near future? Building a large food factory and I love the IE aesthetic so I hope there's some kind of solution available.
I'm having a similar issue, but I don't have Astral Sorcery installed. Here is my mod list: https://i.imgur.com/A0cm0nb.png
I just ran into this bug as well; the same issues, though I haven't tried removing Astral Sorcery yet.
AS 1.10.23
IE 0.12.92
Forge 14.23.5.2854
And a similar thing with crafting torches with a creosote bucket, 1 wool block, and 3 sticks, even when that same assembler makes treated wood just fine.