[1.12] Redstone wire not placable on top half slabs
tomelfring opened this issue ยท 3 comments
Description of the issue:
Redstone is not placable on the slabs of IE. Vanilla redstone can be placed on the top half.
Steps to reproduce:
- Place a treated wood slab on the top half of a block.
- Place a vanilla oak slab on the top half of an other block.
- Try to place redstone on both of them
Crashlog:
No crashlog
Versions & Modlist
Minecraft: 1.12.2
Forge: 14.23.4.2747
Immersive Engineering: 0.12-84
No other mods installed
Lastly (you may delete this from the report itself)
Thank you for all the work! It's an amazing mod with beautiful textures!
Slight note: the contribution guidelines do not show on top anymore, but on the right hand side ;)
Did some digging in the code why this won't work.
Redstone (dust, comparators, repeaters) all use the old method isTopSolid()
(BlockRedstoneWire.canPlaceBlockAt & BlockRedstoneDiode.canPlaceBlockAt).
The method isTopSolid has no arguments, thus it can't be used to support IE slabs as they are tile entities.
Addressed by MinecraftForge/MinecraftForge#5100