Immersive Engineering

Immersive Engineering

134M Downloads

[Suggestion] Scale up fluids/clean up unused slots in JEI

DaedalusGame opened this issue ยท 9 comments

commented

Fluids for IE machines are barely visible in JEI right now, I think it would be better if they scaled up to a certain minimum. It would make JEI recipes much more readable. Example, if something produces only 8 mb of seed oil, and the tank in JEI shows a maximum of 16000 mb, it should render atleast 800 mb. Another idea might be to scale it off the highest amount produced by a recipe, so if there's 3 recipes, one produces 80 mb, one 40 mb and one 20 mb, it will show a full tank, a half tank and a quarter tank for those in JEI.

Additionally it would be good if the unused slots could be removed from the texture in JEI. Maybe the energy bar could actually show much energy will be used by a recipe but that's none of my business.

Pic related:
javaw_8EIFfMaesh
javaw_HhMxSdIAEs
javaw_0IR3JebBJw

Bonus points: these recipes don't fit their allocated boxes in JEI:
javaw_frevt8RSlC
javaw_nY6qZoS7x2

commented

I don't know about removing unused slots from the texture - I feel like barring the inclusion of an image editing library, that'd require a separate texture for everything - but I do like the other ideas!

commented

Yeah, seperate texture is the way to go, other mods already do that kind of stuff.
squeezer
fermenter
refinery

commented

as a compromise, how about putting some funnel shaped icons beneath each tank indicator, fully coloring with the liquid inside the tank, this way the actual indicator would still be up to scale and the small funnel would be an adequate content indicator

just as an additional idea, this would make an wonderfull place to put a click behaviour to lock the tank to the actual fluid, which could come in handy for more complex recipes at some point even

commented

I don't super like the idea of doing separate textures, I think I'll stay with the current ones, becaues it also associates the ingame GUI and JEI display a bit more.
The slots for the Arc Furnace are intentional, because complex recycling recipes may output a bunch of different items, and I dislike the idea of having the slots based on the number of outputs. That would make the JEI display not uniform.
I can definitely look into scaling up the tanks however, and I'll do that for the next release!

commented

The slots for the Arc Furnace are intentional, because complex recycling recipes may output a bunch of different items, and I dislike the idea of having the slots based on the number of outputs. That would make the JEI display not uniform.

I'm talking about the text and the bottom bit of the slots overlapping the JEI boundary. Just adding a little bit more size to the arc furnace real estate and making the coke oven fuel one fill the entire horizontal strip would fix this

Edit: just realized i've formatted the issue poorly, I'll update it to reflect what i was actually referring to

commented

There's another reason to use multiple textures - resource pack support. If you want to change the appearance of JEI's GUI, then you can't alter these to match. In 1.14 for example the 3 different furnaces Mojang added use different GUI textures, even though they're identical.

commented

yeah, multiple textures would also make IE JEI handlers more internally consistent tbh, because the arc smelter and fuel handlers use a different look entirely

commented

That is because the Arc Furnace and the Blast Fuel ones don't use textures at all. They just use some slots, which are drawn in code, because fitting the Arc Furnace GUI in there is impossible.

commented

^ this commit fixes all the "out of area" issues for the Arc Furnace and Blast fuel. It also changed tick-based measurement to show up in Seconds instead, since that is more user friendly.

Tank sizes have been adjusted, most of them are now automatically generated as "4 times the amount produced". This results in all amounts looking the same. It's not idea either, but at least the fluid is visible now. And there's no real other way to do it.