[1.16.5] Fluid Outlets generate some lag
jinkhya opened this issue ยท 2 comments
Description of the issue:
Hello, I'm using some Fluid outlets as decoration to make iron pipes look like they go in the wall and I've noticed in forge track reports and spark profilers that they're using a lot of ticks :
https://spark.lucko.me/Kt57GMRMA3
https://imgur.com/a/RqEoMb9
I have this issue on the server/modpack I play but I was able to reproduce in singleplayer, you'll need Forge 36.1.2, IE 4.2.4-134, sampler :
- create a world
- run /spark tickmonitor
- place about 12 fluid outputs like this for example : https://imgur.com/a/Byt1KIy (you'll see each placement takes about 260-300ms)
- now if you wait a bit, sampler will continue to report salves of ticks that last about 300ms and if you run the /forge tps command, the overall mean tick goes from about 3 ms to 25ms or so when the outputs start checking the area again (guessing that's what happens) : https://imgur.com/a/ObxfedW Each salve happens every 20 seconds or so. The salve is based on when you place the outputs.
- Now close the world, and reopen it and run /spark tickmonitor again. No more salves since all the outputs are loaded at the same time, tickmonitor now reports a bigger number (addition of your 12 outputs) so about 3000ms and overall mean tick goes from 3ms to 35ms every 20 ish seconds.
Sorry about the wall of text, tried to be as specific and clear as possible :) (not sure that whole explanation is that clear but feel free to ask more details if need be !)
Versions & Modlist
Forge 36.1.2
IE 4.2.4-134
Modpack Stacia Expert 1.10.6 : https://gist.github.com/jinkhya/9ed0b3d8987cc71d709ad1cb9e62a8de
I've fixed it for your scenario of empty fluid outlets, a similar issue probably still exists when placing fluid outlets in large existing bodies of fluid and filling them with a matching fluid. I'm keeping the issue open since I want to fix that case as well, just not right now.