Immersive Engineering

Immersive Engineering

134M Downloads

Issue with Fluid Tank

MehVahdJukaar opened this issue ยท 1 comments

commented

So I've noticed that MultiblockPartTileEntity.drain function updates the master block even when it's given a FluidAction.SIMULATE, which it shouldn't do since no content would have changed then. This causes issues for blocks that react to block updates and assume that said drain function wouldn't affect the fluid tank state. I've come across this issue after investigating MehVahdJukaar/Supplementaries#99.
I didn't make a PR because I wasn't exactly sure if this was indeed the case but if it is I think it's just a matter to change a single line in that function to this.multiblock.updateMasterBlock((BlockState)null, doDrain != FluidAction.SIMULATE);

commented

Fixed by commits above