Immersive Engineering

Immersive Engineering

Mods
134M Downloads

[1.18.2] Incorrect model rotation for post transformer, current transformer and razor wire

alanbriolat opened this issue ยท 0 comments

commented

Description of the issue:

The models of post transformer, current transformer and razor wire are rendered 180 degrees rotated from their expected appearance:

2022-04-30_20 35 15

  • Post transformer is floating in mid-air (but as #5243 mentions, collision box and attachment points are where you'd expect them to be if the model was rendered in the right place, and therefore also floating in mid-air)
  • Current transformer dial is facing away from the player when placed, not towards
  • Razor wire wooden ends do not appear on the ends, but in the middle instead

With some digging, 6670871 ("Simplify connector blockstate generation code") stood out as a likely culprit, and indeed when I test at that commit I get the same behaviour as above, but if I test the commit before it, I get the expected behaviour, included here for comparison:

2022-04-30_20 32 34

(This is true even if re-running ./gradlew runData, so it's not just the change in the generated data in those 2 commits, it's actually being generated with different values for rotation.)

I was hoping to submit a pull request instead of a bug report, but I'm not really familiar with Minecraft modding, and I haven't yet figured out what is different about those blocks vs. the other 8 using createHorizontalRotatedBlock - I tested all the others and they weren't noticeably changed by that commit. I'm happy to try and implement a fix if pointed in the right direction.

(This is technically a duplicate of #5243, however I'd suggest #5243 is now a duplicate of this one, since it covers only part of the problems introduced by that refactor commit.)

Crashlog:

(Not a crashing bug.)

Versions & Modlist

  • Minecraft 1.18.2
  • Forge 40.1.0
  • Immersive Engineering 1.18.2-8.0.1-147 (also confirmed in latest 1.18.2 branch, revision a4ead70)

Bug is reproducible with just the above, however rest of mod list included for completeness:

  • Configured 1.5.3
  • Cloth Config v4 API 6.2.57
  • Xaero's Minimap 22.6.0
  • Xaero's World Map 1.20.6
  • Refined Storage 1.10.2
  • Architectury 4.2.50
  • Light Overlay 6.0.5
  • Just Enough Items 9.5.5.174