Immersive Intelligence

Immersive Intelligence

2M Downloads

[BUG]Broken zinc and platinum rod recipes

Bananek120 opened this issue ยท 1 comments

commented

Describe the bug
Zinc and platinum rods are uncraftable because of missing outputs in their recipes.

To Reproduce
Steps to reproduce the behavior:

  1. Build a metal press
  2. Attach a rod mold
  3. Drop either a zinc or platinum ingot into the press
  4. Watch the metal disintegrate upon impact
  5. No rods :(

Expected behavior
The press actually produces the rods.

Screenshots or GIFs
obraz
obraz

Logs
latest.log

Environment

  • OS: Windows 10
  • Minecraft version: 1.12.2
  • Forge version: 1.12.2-14.23.5.2859
  • Immersive Intelligence version: 0.2.1
  • Immersive Engineering version: 0.12-98
    Mods:
    ae2stuff-0.7.0.4-mc1.12.2
    AE2WTLib-1.12.2-1.0.34
    AIImprovements-1.12-0.0.1b3
    alternatingflux-0.12.2-2
    AppleSkin-mc1.12-1.0.14
    appliedenergistics2-rv6-stable-7
    autooredictconv-1.12-1.0.1
    Baubles-1.12-1.5.2
    bdlib-1.14.3.12-mc1.12.2
    BiomesOPlenty-1.12.2-7.0.1.2444-universal
    Chameleon-1.12-4.1.3
    Chisel-MC1.12.2-1.0.2.45
    Clumps-3.1.2
    CodeChickenLib-1.12.2-3.2.3.358-universal
    Controlling-3.0.10
    CraftTweaker2-1.12-4.1.20.673 (before you ask, no, I haven't touched press recipes)
    CTM-MC1.12.2-1.0.2.31
    DefaultOptions_1.12.2-9.2.8
    DurabilityViewer-1.12-forge14.21.1.2387-1.6
    engineersdecor-1.12.2-1.1.3
    engineerstools-1.12.2-1.0.5
    engineers_doors-1.12.2-0.9.1
    FastWorkbench-1.12.2-1.7.3
    foamfix-0.10.14-1.12.2
    ForgeMultipart-1.12.2-2.6.2.83-universal
    FTBBackups-1.1.0.1
    Hwyla-1.8.26-B41_1.12.2
    ImmersiveCables-1.12.2-1.3.2
    ImmersiveEngineering-0.12-98
    immersiveintelligence-0.2.1
    immersivepetroleum-1.12.2-1.1.10
    ImmersivePosts-0.2.1
    InventoryTweaks-1.63
    ironchest-1.12.2-7.0.72.847
    jei_1.12.2-4.16.1.302
    journeymap-1.12.2-5.7.1
    JustEnoughResources-1.12.2-0.9.2.60
    LagGoggles-1.12.2-5.8-132
    LoadingProfiler-MC1.12-1.3
    Mantle-1.12-1.3.3.55
    MCTImmersiveTechnology-1.12.2-1.9.99
    mdecore-1.12-1.1
    modtweaker-4.0.20.5
    Morpheus-1.12.2-3.5.106
    MTLib-3.0.7
    NetherPortalFix_1.12.1-5.3.17
    OfflineSkins-1.12.2-v6
    OpenBlocks-1.12.2-1.8.1
    OpenModsLib-1.12.2-0.12.2
    OptiFine_1.12.2_HD_U_G5
    p455w0rdslib-1.12.2-2.3.161
    Patchouli-1.0-23.6
    Placebo-1.12.2-1.6.0
    randompatches-1.12.2-1.22.1.10
    reauth-3.6.0
    rockytweaks-1.12.2-0.6.0-PRE-RELEASE-3
    Sound-Physics-Mod-1.12.2
    soundreloader-1.2-1.12.2
    StorageDrawers-1.12.2-5.4.2
    TickCentral-3.2
    Toast+Control-1.12.2-1.8.1
    VanillaFix-1.0.10-150
    Wawla-1.12.2-2.6.275
    Waystones_1.12.2-4.1.0
    WirelessCraftingTerminal-1.12.2-3.12.97
    ChickenASM-1.12-1.0.2.7
    OfflineSkins-1.12.2-v6-core
commented

Upon investigation, I noticed this is a problem coming from the Immersive Post Helper class.
On line 89 in ImmersivePostHelper.java you change the hidden property of metaitems 2 and 3 of the rods. If you move this to the preInit, this will fix the issue and still work as intended.

The reasoning behind this change is (I think) that the recipes for these rods are being created while the meta is still not unhidden (some form of race condition?). When this is done in the preinit phase, this is all fixed and you do not even need to specifically register the sticks in the oredictionary anymore as they get included when their meta is unhidden.
Something like that. I tested my proposed fix locally and it seemed to have fixed it.