Immersive Melodies [Fabric/Forge]

Immersive Melodies [Fabric/Forge]

7M Downloads

Midis now auto-repeat

CommanderLouiz opened this issue ยท 2 comments

commented

Describe the bug
After updating to verson 0.4.0, I've noticed that all of the midis I play seem to auto-repeat. For some, this is nice, especially if its a song that already loops naturally. But for other shorter ones, not so nice.

Latest.log
There's nothing useful in the log.

To Reproduce
Download this midi, and import it into the game. Play it.

Expected behavior
The instrument plays the winning jingle once, and then stops.

Instead, it loops and plays repeatedly until you pause or scroll off of the instrument.

Screenshots
N/A

Additional context
Admittedly, this isn't a very big issue, as you can either just pause the playback, switch to a different song, or stop holding the instrument.

commented

Yes, the reason for this was that all other entities repeat and the player being the only exception felt off. I need to think about how to make this better :)

commented

I think the player being the only exception makes sense.
I'm the player, I want to have that level of control over the music I play.

Perhaps another button on the bottom, next to the pause and play. A little loop icon that you can toggle.