Immersive Melodies [Fabric/Forge]

Immersive Melodies [Fabric/Forge]

2M Downloads

Add an option to allow uploading custom music tracks but not converting abc to midi

Blayung opened this issue ยท 9 comments

commented

I'm unsure whether the conversion happens on the client on the server, if it's on the client then you can simply close this issue.

commented

Parsing ABC files is extremely complicated, the conversion to midi is therefore necessary.

commented

I meant, if a player tries to upload an abc file, the server will just reject it.

commented

Then I would need said ABC to debug :)

commented

Huh?

commented

The file. Upload it here. How should I debug a crashing file without the file? ^^

commented

Okay, sorry if I didn't communicate it clearly, but I meant to add an option on the server to reject abc files. I'm not having problems with the server rejecting files, I want it to do it.

commented

When I don't want the server to send queries to your api. Unless,

I'm unsure whether the conversion happens on the client on the server, if it's on the client then you can simply close this issue.

commented

In what scenario does this make sense?

commented

Ah I see, yes the conversion is client sided.