Immersive Railroading

Immersive Railroading

Mods
3M Downloads

Localisation crash [crash fixed, translations still funky]

baysupercool opened this issue · 26 comments

commented

Minecraft version: 1.16.5
Forge version: 36.2.2
UMC version: 1.1.0
TrackAPI version: 1.2.1
Immersive Railroading version: 1.9.0

Expected result: Game launches successfully

Actual result: java.lang.ExceptionInInitializerError: null

Reproducing:

  1. This crash is only reproducible with certain languages (in my case Turkish), set the computer language to one of these
  2. Launch the game
  3. See the error screen

The crash report points to UMC but loading UMC alone doesn't crash, hence why I reported here.

crash-2021-08-02_16.53.07-fml.txt

latest.log

commented

Interesting:

Exception message: net.minecraft.util.ResourceLocationException: Non [a-z0-9/._-] character in path of location: forge:barsıron
commented

I'll try to put together a test UMC jar to send your way shortly

commented

Game still crashes with error java.lang.ExceptionInInitializerError but this time exception message is:
Exception message: net.minecraft.util.ResourceLocationException: Non [a-z0-9/._-] character in path of location: immersiverailroading:raıl

commented

Can you post the full log?

commented

Can you post the generated universalmodcore.cfg file?

Thanks for your patience and help debugging!

commented

Ok so I deleted the config files and let them regenerate. Game launches fine for the first time.
Log for the first time:
first log.log

But when I try to launch the game for the second time I get an error saying that UMC cannot read the config file.
crash-2021-08-02_22.59.37-fml.txt
latest.log

commented

universalmodcore.txt

commented

Ok, I had fixed all of the toLowerCase, missed a toUpperCase.

Here's the build: https://teamopenindustry.cc/maven/cam72cam/universalmodcore/UniversalModCore/1.16.5-forge-1.1.1-0adb54/UniversalModCore-1.16.5-forge-1.1.1-0adb54.jar

You will need to remove the universalmodcore.cfg again

commented

This build doesn't crash!!!

There are missing names for some items, though. Which are:
Firebox
Piping
Boiler segment
Boiler
Whistle
Eccentric rod
Eccentric crank
Main rod
Side rod etc.
Basically anything with the letter "i" in it.

Other than that everything seems fine.

commented

Ok, cool. I'll include this in the next UMC release and will also fix it in ImmersiveRailroading, though I may not release the IR changes as soon.

commented

That should fully resolve the problem

commented

I got the same crash at the first post.
latest.log
crash-2021-08-03_10.50.49-fml.txt

commented

Whenever I try to create a new world I get an error saying:
Errors in currently selected datapacks prevent the world from loading. You can either try to load it with only the vanilla datapack ("safe mode"), or go back to the title screen and fix it manually.

latest.log

commented

damn, I'll need to think about how I could have broken that :/

commented

Adding onto my last message:
I downloaded a mod that adds steel and tried to create a world, it worked fine. Weird.
Also many items are missing their names:
2021-08-03_23 07 26

commented

yeah, I think that's because I don't have any turkish translations provided for IR?

commented

That is quite strange, I set my local minecraft to TR and the IR translations came through in english as expected.

commented

I mean mods default to English translations when they don't have translations for the selected language

commented

I set my minecraft language to EN and there are still missing names, only names that are not missing are the rolling stock.
latest.log

commented

I'm going to need to change my system language and test this more over the coming days.