Passenger pose improvements
CherubAgent1440 opened this issue ยท 1 comments
Currently, a model made at 2 foot gauge (MC gauge) will default the player to be always sitting, meaning that almost all 2ft modellers need to set the should_sit
flag to false
in the json's passenger
section. This wasn't a problem historically, since unless you used the trains on model gauge for a miniature railway, it didn't look out of place.
However, we now have working SEAT
parts. And if the should_sit
flag is set to false, then even when you are sitting on a SEAT
then you are made to be standing.
I can think of four potential options to improve this:
- The cutoff for automatically sitting is at gauges less than MC gauge, instead of less than or equal to. Since pretty much all railways smaller than 2 foot are miniature railways, for which you pretty much can't stand in anyway, then that should be all right. Only issue is existing MC gauge trains that want you to be always sitting but don't include the flag because it wasn't necessary.
- If the model contains
SEAT
parts, then whenshould_sit
is not specified, the default is standing regardless of the gauge. This is unlikely to be a problem because the use ofSEAT
parts is unlikely where you are seated by default, and in the unlikely situation where it is,SEAT
parts are sufficiently new that the modeller will likely still be active. - If you are sitting in a seat you are always sitting even if
should_sit
isfalse
. This might break things where aSEAT
is used to represent a place to stand that is outside of the walkable area, e.g. a cupola on a caboose. - Another flag, something like
should_sit_in_seats
, which controls whether you should sit or stand inSEAT
parts. If its default value is the same as the value ofshould_sit
, then it won't break any current models. If its default value istrue
then it feels more intuitive, and as with point 2, any modellers who usedSEAT
parts are still active and can release a hotfix.