Immersive Railroading

Immersive Railroading

3M Downloads

Resouce Leak

ichttt opened this issue ยท 1 comments

commented

Hi, you are leaking some resources. Every IResource you get here: https://github.com/cam72cam/ImmersiveRailroading/blob/660c8aadc1ea61751271778434dd282b6251e79f/src/main/java/cam72cam/immersiverailroading/proxy/ClientProxy.java#L362 or https://github.com/cam72cam/ImmersiveRailroading/blob/660c8aadc1ea61751271778434dd282b6251e79f/src/main/java/cam72cam/immersiverailroading/proxy/ClientProxy.java#L367 needs to be closed in a try-with-resources or try-finally block

These leaks can be observed by forcing debug to be enabled for minecraft loggers using the log4j xml

commented

Thanks for the heads up!