[1.14.4] [Forge] Crash on startup with Botania
ToMe25 opened this issue ยท 9 comments
Version Information
Minecraft 1.14.4
Forge 28.2.3/28.2.1/28.2.0
Track API 1.2
Immersive Railroading 1.7.3
Curios 1.0.6.1
Patchouli 1.1-26
Botania r1.11-378
Further Information
Link to crash log: latest.log
Botania Issue: VazkiiMods/Botania#3227
It didn't happen without it.
Edit: sorry, i have mistaken this issue for another one, VanillaFix wasn't installed.
This is almost definitely (99%) not a botania issue. Botania's rendering needs are dead simple in comparison to IR and our log is clean on startup, modulo some json texture errors which are benign under forge and botania alone (and I suspect to be caused by other forge bugs).
IR spams the log with tons of texture and model errors even when loading alone. I would bet if those were fixed, this issue would also be fixed. I suspect forge may have buggy error handling that causes errors earlier during model loading to put the model registry in an inconsistent state. When Botania queries the registry to get some models it needs it then blows up (what you see in GunModel at the bottom)
In short, nothing I can do.
@williewillus what's the story behind VazkiiMods/Botania@76f116d ?
@cam72cam Forge keeps on loading for some reason even though critical errors have happened early in startup. We were getting lots of crash reports where our ModelBakeEvent was seemingly implicated when it was just the fact that the model registry had not loaded fully due to an earlier error from another mod. So that was added to just skip our ModelBakeEvent handler if our ModelRegistryEvent handler did not get called. Still not foolproof though.
Anyhow, glad the issue has been resolved.
@williewillus I think I found the problem. I was accessing the resource manager before it was properly initialized and it may have borked something internal to forge. When I moved stuff from Setup to Init, it seemed to solve the problem: TeamOpenIndustry/UniversalModCore@4bbeaaf
Thanks, the Crash is fixed with that versions, i will close this Issue once a build of that is on curseforge :)