Immersive Weathering [FABRIC]

Immersive Weathering [FABRIC]

Mods
6M Downloads

ClientDynamicResourcesHandler autogenerates based off of bark, even for modded woods that should have scales instead

f-raZ0R opened this issue ยท 0 comments

commented

Describe the bug:
The code for autogenerating bark items seems to... not actually do anything differently besides changing the item's id? So despite correctly going "yeah this is Mushroom, this should be scales instead", IW will still go through the steps of... making it a bark.

Immersive-Weathering/common/src/main/java/com/ordana/immersive_weathering/dynamicpack/ClientDynamicResourcesHandler.java

Line 148 in 9ea94e1

addSimilarJsonResource(manager,itemModel, "oak_bark", id);

right here, for example, there is no check for "hey wait these are scales instead! we shouldn't be basing this off of oak bark!"

Here is an image of a "bark".
2024-10-21_11 41 08

Other mods:
N/A,
Logs:
N/A, this is simply due to there not being any code to account for autogenerated scales in ClientDynamicResourcesHandler. The source of the bug is already known.

To Reproduce:

  1. Have IW, and any other mod that adds a woodtype that returns false for type.canBurn()
  2. Look at the very much not scaly bark, that still says "scales" with F3+H

Expected behavior:
These autogenerated scales would be based off of the scales sprite instead of the bark sprite, and have "Scales" in their name instead of Bark.