ImmersiveMC

ImmersiveMC

2M Downloads

Deeper and Darker Chest Lid Incompatibility

hammy275 opened this issue ยท 3 comments

commented

Caused by this mixin: https://github.com/KyaniteMods/DeeperAndDarker/blob/master/common/src/main/java/com/kyanite/deeperdarker/mixin/containers/ChestEntityMixin.java . Their recheckOpeners function completely bypasses the original call, so ImmersiveMC's mixin into it is effectively useless.

The true problem is:

#143 's fix means we can't do anything with getOpenCount(), as the mixin in the library there bypasses that function call entirely.
This fix means we can't do anything with recheckOpeners(), as the mixin in Deeper and Darker bypasses that function entirely.

Seems like here we'd want to do a fix specific for Deeper and Darker.

I need to sit a bit on the solution for this, so I don't know if it'll make it to 1.2.2's release (which ideally, is what I'd want to do). We can't simply mixin to our original mixin point from before #143 , as mixing into both spots would cause the count to be incorrect, which causes problems with trapped chests. Even if we check in the spot before #143 for Deeper and Darker, that means if both Deeper and Darker and the library are installed, ImmersiveMC's mixin is entirely bypassed!

commented

Will be submitting a PR to Deeper and Darker to fix this.

Opened at KyaniteMods/DeeperAndDarker#125

commented

PR was merged! ๐ŸŽ‰

Going to leave this open until the next Deeper and Darker update so I can track it. Once it's out, I can update the CurseForge page to have people upgrade and close this issue.

commented

Should be fixed as of Deeper and Darker 1.2.0 now.