ImmersiveMC

ImmersiveMC

683k Downloads

Immersives Linger After Explosions

hammy275 opened this issue ยท 2 comments

commented

Also from /setblock.

commented

Note to self:

ImmersiveHitboxes returns false from shouldTrack, so we can't just hook into that. Need to investigate if flipping that to true would break things. ImmersiveBackpack handles having it always return true

EDIT: Looks like ImmersiveBackpack can return true because its trackObject implementation is a no-op, which is also the case in ImmersiveHItboxes. So we should be good to flip the shouldTrack to return true in ImmersiveHitboxes and go from there, which would be adding an else to the shouldTrack check in ClientLogicSubscriber (not in AbstractImmersive's tick(), since that depends on the tick from ClientLogicSubscriber being called) to simply call info.remove().

commented

With the above in mind, should also remove the ImmersiveBreakPacket, since clients now decide on their own when to stop tracking immersives.