Beacon Crashes Game
hammy275 opened this issue ยท 5 comments
Should be an issue on MC VR API's side, so I'm closing this. If it pops up again and I have reproduction steps, I'll re-open it on MC VR API's side.
Welp, I have reproduction steps for this now.
On 1.20.4 NeoForge, building a beacon, then confirming an immersive selection, the game crashes with the error this issue was made from.
Likely a MC VR API issue still, but I definitely need to fix this before 1.5.0 Alpha 2 releases.
Opened at hammy275/mc-vr-api#44 .
On the ImmersiveMC end for correctness, we should optionally depend on MC VR API where possible, so ImmersiveMC loads after it. Not necessarily required it seems, but would make sense for correctness, and incase it's needed later.
EDIT: There is another issue on ImmersiveMC's end that we need to account for. MC VR API's behavior is "undefined" when triggering a rumble outside of VR, and we seem to determine the player is in VR when they actually aren't for some reason.
Figured out the reason for the above. On the client, we pass null as the player when rumbling client-side, so we never check if they're actually in VR before rumbling.
This is the core of the issue. Originally, I thought this issue didn't happen on Fabric, but in actuality, it does, I just had controller rumble disabled.