ImmersiveMC

ImmersiveMC

2M Downloads

Genericize Crafting Table Detection

hammy275 opened this issue ยท 6 comments

commented

Already done for other blocks, should do it for crafting tables, too.

commented

Done and done!

commented

Had to undo the work from this due to a bug with smithing tables (see #371 ). I'm thinking of using a user-customizable whitelist in the future, but until then, this issue is back open.

commented

I should use tags for this. Great system already in the game. I can internally keep a list of all crafting tables I know are supported, and it should let authors add their own through the vanilla tag system (will have to write a wiki article for that).

commented

I should be able to detect crafting tables using each modloader's pre-existing crafting table tag combined with the new convention one (https://github.com/FabricMC/fabric/blob/e521378444edf1a1f4d41311b8be7edf2c17aef1/fabric-convention-tags-v2/src/generated/resources/data/c/tags/block/player_workstations/crafting_tables.json).