ImmersiveMC

ImmersiveMC

2M Downloads

Apotheosis Compatibility

hammy275 opened this issue ยท 12 comments

commented

Luckily, I moved the enchanting table to the declarative immersive system, so I can use a clone of the vanilla one as a base.

Would want to add:

  • The Eterna/Quanta/Arcana bars. If possible, viewing the description for what they are would be great when looked at/pointed at.
  • A rectification bar, maybe?
  • Support for enchantment previews to be an arbitrary number of clues, rather than just 1.
commented

Once #407 is done, we can display the bars on the enchantment table's book, rather than in a floating UI.

commented

On top of the enchantment table book showing Eterna, Quanta, Arcana, and maybe rectification, we should also support the other GUI blocks Apotheosis adds similarly to the anvil/smithing table.

commented

I have what I would describe as "most" of the compatibility done at 5f7c947. I do want to do the above in a book still, so I'll do that, merge the commits, then propagate to other branches.

In terms of propagation, branches will get the Apotheosis version based on their closest Minecraft version. For example, even though Apotheosis 1.19.4 doesn't exist, it will get the 1.19.2 Apotheosis, since they're both the 1.19.x line. modCompileOnly will be used so we don't actually have to worry about the version mismatch but still be good to compile. Doing this so ImmersiveMC's codebase remains as consistent as possible between Minecraft versions.

commented

Note to self: Need to also handle allowing insertion of items that can be infusion-crafted.

commented

New commit, handles the note above and the book: 0bda20f .

Going to do the other Apotheosis workbenches, then I'll start porting to other versions. Very little code is Apotheosis-specific, just the small compatibility modules, so hopefully this won't be too much of a pain to move over (still have to deal with differences between Minecraft versions).

commented

Other things left:

  • Genericize chiseled bookshelf to allow shelf of aquatic filtration to work.
  • Salvaging table (have some slots on top, which morph into the outputs upon punching block
  • Gem cutting table
  • Reforging table (maybe)
commented

Chiseled bookshelf genericize done at 21775e0

commented

Salvaging table done in 054fc0e

commented

Looks like for the other two, we should add a feature to ImmersiveMC to allow showing an item "preview". This could also be used on the smithing table.

Definitely needs to be in the builder, too.

Previews should support showing any of the following, rendered at some transparency within the item guide (or something like that):

  • All items in a tag (would all assume quantity 1)
  • A list of ItemStacks (including quantity)