ImmersiveMC

ImmersiveMC

2M Downloads

Shield Doesn't Reflect on Multiplayer 1.5.0 Beta 1

hammy275 opened this issue ยท 3 comments

commented

The reflect sound effect plays, but the player still takes damage. Seems like we may only be blocking on the client? The block works fine on singleplayer though, so that's fun.

https://discord.com/channels/1061675558347489343/1254860540665401445/1255166768205266975

commented

Someone else was able to replicate this under 1.4.1 instead of 1.5.0 beta 1: https://discord.com/channels/1061675558347489343/1280614620213543002/1280614620213543002. Lots of important details in that thread.

EDIT: Likely not the same bug as above, but I'm going to lump these two together since I want to get the shield fully fixed by next beta.

commented

Putting a third shield bug here: A non-VR user hitting a VR user hears the melee hit, but the damage does not actually go through. Obvious enough to me why this happens, the other player doesn't know the position and rotation of the controller to determine if the hit was blocked.

For fixing this, until the official Vivecraft API comes in (at which point we'll have access to VR data for other players anyways), I think I'll just sync VR data of other players if they're holding a shield in the mainhand or offhand.

commented

This issue so far has three comments, excluding this one. To organize things:

  1. Either the same as (2), or unreproducible.
  2. Spun off into #448, since that was the core of the issue.
  3. Will likely wait until Vivecraft's official API is in, so I don't have to sync data separately.

With all that said, this issue is now just (3), so going to move this out of 1.5.0 Beta 2.